Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set environment variables for common build tools #53

Merged

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 29, 2018

Includes a few other environment variables for other command line tools. Should aid in the migration to the new toolchain, which sets these as well.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Make sure some other common compilation tools have environment variables
set for them as well for easy use. Should aid in migrating to the new
toolchain, which provides and sets all of these.
Includes some common environment variables specifying where to find
these command line tools for the legacy toolchain. Should aid in
migration to the new toolchain, which both provides these tools and sets
environment variables pointing to them.
Make a new release with the minor version number bumped as we include
environment variables pointing to other common toolchain tools to smooth
over differences between the legacy and new toolchains thus aiding the
migration.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The outputs section contained an unexpected subsection name. run_exports is not a valid subsection name.

For recipe:

  • It looks like the 'm2w64-toolchain_' output doesn't have any tests.

@jakirkham
Copy link
Member Author

Thoughts @conda-forge/core?

Copy link
Member

@mariusvniekerk mariusvniekerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this makes things behave more similarly to anaconda recipes

@jakirkham
Copy link
Member Author

Appears a few people have looked. Am going to go ahead and merge this to unblock the rebuild of opencv. Please let us know if there are issues or concerns and we can follow-up. Thanks.

@jakirkham jakirkham merged commit e4a9e8a into conda-forge:master Dec 30, 2018
@jakirkham jakirkham deleted the set_envs_cmd_line_tools branch December 30, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants